fix(toolkit): disallow none combined with other prompts in oidcPromptsGuard (#9565) - #9596
Open
Tyagiquamar wants to merge 4 commits into
Open
Tyagiquamar wants to merge 4 commits into
Tyagiquamar wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The published package needs a patch changeset, and one test name is inaccurate.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds OIDC validation preventing none from being combined with other prompts.
Changes:
- Adds mutually exclusive prompt validation.
- Adds unit tests for valid and invalid combinations.
File summaries
| File | Description |
|---|---|
social.ts |
Adds OIDC prompt validation. |
social.test.ts |
Tests prompt validation behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
wangsijie
reviewed
Sep 14, 2026
wangsijie
left a comment
wangsijie
left a comment
Contributor
There was a problem hiding this comment.
Please take a look at copilot's comments
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changeset should describe user-facing behavior rather than the internal guard implementation.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
…figurations Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
wangsijie
force-pushed
the
fix/oidc-prompt-none-validation
branch
from
September 15, 2026 06:14
d8d03f6 to
3d5655b
Compare
wangsijie
approved these changes
Sep 15, 2026
wangsijie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9565
Description
oidcPromptsGuard allowed
one when combined with other prompt values (such as select_account or consent). According to OIDC Core 1.0 §3.1.2.1,
one cannot be combined with any other prompt value.
This PR adds a .refine() validation check to oidcPromptsGuard in packages/toolkit/connector-kit/src/types/social.ts to reject
one when combined with other prompts, and adds unit tests.